From: Ioana Ciornei Date: Tue, 13 Aug 2019 12:43:04 +0000 (+0300) Subject: staging: fsl-dpaa2/ethsw: remove redundant VLAN check X-Git-Tag: for-linus-2019-09-27~94^2~142 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=e76d3d60e3bb918fffb1af3558fe34cd3ea2116b;p=linux-block.git staging: fsl-dpaa2/ethsw: remove redundant VLAN check The ethsw_add_vlan() function is already called only when the VLAN is not yet configured on the switch. Remove the redundant check. Reported-by: Andrew Lunn Signed-off-by: Ioana Ciornei Link: https://lore.kernel.org/r/1565700187-16048-8-git-send-email-ioana.ciornei@nxp.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c index 20519af4d804..b69b2b7be972 100644 --- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c +++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c @@ -34,11 +34,6 @@ static int ethsw_add_vlan(struct ethsw_core *ethsw, u16 vid) .fdb_id = 0, }; - if (ethsw->vlans[vid]) { - dev_err(ethsw->dev, "VLAN already configured\n"); - return -EEXIST; - } - err = dpsw_vlan_add(ethsw->mc_io, 0, ethsw->dpsw_handle, vid, &vcfg); if (err) {