From: Mathieu Malaterre <malat@debian.org>
Date: Thu, 22 Mar 2018 21:05:28 +0000 (+0100)
Subject: cxl: remove a dead branch
X-Git-Tag: for-linus-20180825~59^2~14
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=e4ecafb14fd9cd77d8f4320af1922e700db56d2b;p=linux-block.git

cxl: remove a dead branch

In commit 14baf4d9c739 ("cxl: Add guest-specific code") the following code
was added:

	if (afu->crs_len < 0) {
		dev_err(&afu->dev, "Unexpected configuration record size value\n");
		return -EINVAL;
	}

However the variable `crs_len` is of type u64 and cannot be compared < 0.
Remove the dead code section. Fix the following warning treated as error
with W=1:

../drivers/misc/cxl/guest.c:919:19: error: comparison of unsigned expression < 0 is always false [-Werror=type-limits]

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---

diff --git a/drivers/misc/cxl/guest.c b/drivers/misc/cxl/guest.c
index f5dc740fcd13..3bc0c15d4d85 100644
--- a/drivers/misc/cxl/guest.c
+++ b/drivers/misc/cxl/guest.c
@@ -913,11 +913,6 @@ static int afu_properties_look_ok(struct cxl_afu *afu)
 		return -EINVAL;
 	}
 
-	if (afu->crs_len < 0) {
-		dev_err(&afu->dev, "Unexpected configuration record size value\n");
-		return -EINVAL;
-	}
-
 	return 0;
 }