From: Ilpo Järvinen Date: Fri, 7 Mar 2025 14:09:22 +0000 (+0200) Subject: PCI: Do not claim to release resource falsely X-Git-Tag: block-6.15-20250403~40^2~22^2~9 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=e4cb29386ffc1d12885e412232adf361c77a93ac;p=linux-block.git PCI: Do not claim to release resource falsely pci_release_resource() will print "... releasing" regardless of the resource being assigned or not. Move the print after the res->parent check to avoid claiming the kernel would be releasing an unassigned resource. Likely, none of the current callers pass a resource that is unassigned so this change is mostly to correct the non-sensical order than to remove errorneous printouts. Link: https://lore.kernel.org/r/20250307140922.5776-1-ilpo.jarvinen@linux.intel.com Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas --- diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c index b056acfda96c..c6657cdd06f6 100644 --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c @@ -411,11 +411,11 @@ void pci_release_resource(struct pci_dev *dev, int resno) struct resource *res = pci_resource_n(dev, resno); const char *res_name = pci_resource_name(dev, resno); - pci_info(dev, "%s %pR: releasing\n", res_name, res); - if (!res->parent) return; + pci_info(dev, "%s %pR: releasing\n", res_name, res); + release_resource(res); res->end = resource_size(res) - 1; res->start = 0;