From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Wed, 16 Apr 2025 09:55:12 +0000 (+0300)
Subject: gpiolib: Revert "Don't WARN on gpiod_put() for optional GPIO"
X-Git-Tag: v6.16-rc1~169^2~57
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=df6dccb4aeab5f19c8451d960259fd1d911f3129;p=linux-block.git

gpiolib: Revert "Don't WARN on gpiod_put() for optional GPIO"

No need to double check the pointer for NULL since gpiod_free()
is using VALIDATE_DESC_VOID() which simply returns in that case.

This reverts commit 1d7765ba15aca68f3bc52f59434c1c34855bbb54.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250416095645.2027695-5-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
---

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index e8e75da7b177..7ab408b44893 100644
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -5140,8 +5140,7 @@ EXPORT_SYMBOL_GPL(gpiod_get_array_optional);
  */
 void gpiod_put(struct gpio_desc *desc)
 {
-	if (desc)
-		gpiod_free(desc);
+	gpiod_free(desc);
 }
 EXPORT_SYMBOL_GPL(gpiod_put);