From: Johan Hovold Date: Thu, 23 Jul 2020 12:33:26 +0000 (+0200) Subject: serial: pmac_zilog: add sparse context annotation X-Git-Tag: v5.9-rc1~118^2~18 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=de5b2c9d16924ad0d9e2bfd9a5da16fe6ea54f22;p=linux-block.git serial: pmac_zilog: add sparse context annotation Add sparse context annotation to the receive handler, which releases and reacquires the port lock, to silence a sparse warning: drivers/tty/serial/pmac_zilog.c:255:36: sparse: sparse: context imbalance in 'pmz_receive_chars' - unexpected unlock Reported-by: kernel test robot Signed-off-by: Johan Hovold Reviewed-by: Andy Shevchenko Link: https://lore.kernel.org/r/20200723123327.5843-2-johan@kernel.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/pmac_zilog.c b/drivers/tty/serial/pmac_zilog.c index ba65a3bbd72a..96e7aa479961 100644 --- a/drivers/tty/serial/pmac_zilog.c +++ b/drivers/tty/serial/pmac_zilog.c @@ -213,6 +213,7 @@ static void pmz_interrupt_control(struct uart_pmac_port *uap, int enable) } static bool pmz_receive_chars(struct uart_pmac_port *uap) + __must_hold(&uap->port.lock) { struct tty_port *port; unsigned char ch, r1, drop, flag;