From: Eric Auger <eric.auger@redhat.com>
Date: Tue, 30 Apr 2019 07:30:04 +0000 (+0200)
Subject: iommu/vt-d: Fix leak in intel_pasid_alloc_table on error path
X-Git-Tag: for-linus-20190516~6^2^5
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=dca4d60f5f8c9263f8f66724fa4750abd32d8db0;p=linux-block.git

iommu/vt-d: Fix leak in intel_pasid_alloc_table on error path

If alloc_pages_node() fails, pasid_table is leaked. Free it.

Fixes: cc580e41260db ("iommu/vt-d: Per PCI device pasid table interfaces")

Signed-off-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---

diff --git a/drivers/iommu/intel-pasid.c b/drivers/iommu/intel-pasid.c
index 03b12d2ee213..2fefeafda437 100644
--- a/drivers/iommu/intel-pasid.c
+++ b/drivers/iommu/intel-pasid.c
@@ -154,8 +154,10 @@ int intel_pasid_alloc_table(struct device *dev)
 	order = size ? get_order(size) : 0;
 	pages = alloc_pages_node(info->iommu->node,
 				 GFP_KERNEL | __GFP_ZERO, order);
-	if (!pages)
+	if (!pages) {
+		kfree(pasid_table);
 		return -ENOMEM;
+	}
 
 	pasid_table->table = page_address(pages);
 	pasid_table->order = order;