From: Guilherme G. Piccoli Date: Thu, 6 Oct 2022 22:42:05 +0000 (-0300) Subject: pstore: Improve error reporting in case of backend overlap X-Git-Tag: io_uring-6.2-2022-12-19~129^2~11 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=d85644dc5cf4023bf1a325f476d58a16bcc0798b;p=linux-block.git pstore: Improve error reporting in case of backend overlap The pstore infrastructure supports one single backend at a time; trying to load a another backend causes an error and displays a message, introduced on commit 0d7cd09a3dbb ("pstore: Improve register_pstore() error reporting"). Happens that this message is not really clear about the situation, also the current error returned (-EPERM) isn't accurate, whereas -EBUSY makes more sense. We have another place in the code that relies in the -EBUSY return for a similar check. So, make it consistent here by returning -EBUSY and using a similar message in both scenarios. Signed-off-by: Guilherme G. Piccoli Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20221006224212.569555-2-gpiccoli@igalia.com --- diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c index 0c034ea39954..c32957e4b256 100644 --- a/fs/pstore/platform.c +++ b/fs/pstore/platform.c @@ -562,8 +562,9 @@ out: int pstore_register(struct pstore_info *psi) { if (backend && strcmp(backend, psi->name)) { - pr_warn("ignoring unexpected backend '%s'\n", psi->name); - return -EPERM; + pr_warn("backend '%s' already in use: ignoring '%s'\n", + backend, psi->name); + return -EBUSY; } /* Sanity check flags. */