From: Stephen M. Cameron <stephenmcameron@gmail.com>
Date: Wed, 7 Mar 2012 18:37:57 +0000 (+0100)
Subject: gfio: fix problem with graph finding data range.
X-Git-Tag: gfio-0.1~225
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=d582bf70449c1ebbd96f9afa3b2e37dcc7dfb11f;p=fio.git

gfio: fix problem with graph finding data range.

In finding minimum value, it used zero as an initializer
but if the graph had no data below say, 1000, it would still
find zero as the minimum, which was incorrect.

Signed-off-by: Stephen M. Cameron <scameron@beardog.cce.hp.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---

diff --git a/graph.c b/graph.c
index d3fcb8db..40c5256b 100644
--- a/graph.c
+++ b/graph.c
@@ -383,13 +383,18 @@ static double gety(struct graph_value *v)
 
 static double find_xy_value(struct graph *g, xy_value_extractor getvalue, double_comparator cmp)
 {
-	double tmp, answer = 0.0;
+	double tmp, answer;
 	struct graph_label *i;
 	struct graph_value *j;
+	int first = 1;
 
 	for (i = g->labels; i; i = i->next)
 		for (j = i->values; j; j = j->next) {
 			tmp = getvalue(j);
+			if (first) {
+				first = 0;
+				answer = tmp;
+			}
 			answer = cmp(tmp, answer);	
 		}
 	return answer;