From: Alexey Khoroshilov <khoroshilov@ispras.ru>
Date: Thu, 6 Feb 2014 00:47:13 +0000 (+0100)
Subject: staging: gdm72xx: fix leaks at failure path in gdm_usb_probe()
X-Git-Tag: v3.14-rc3~12^2~16
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=d3a874e899b073496d1fe89b6a2d1aa50870874d;p=linux-block.git

staging: gdm72xx: fix leaks at failure path in gdm_usb_probe()

Error handling code in gdm_usb_probe() misses to deallocate
tx_ and rx_structs and to do usb_put_dev().

Found by Linux Driver Verification project (linuxtesting.org).

Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/gdm72xx/gdm_usb.c b/drivers/staging/gdm72xx/gdm_usb.c
index f8788bf0a7d3..cdeffe75496b 100644
--- a/drivers/staging/gdm72xx/gdm_usb.c
+++ b/drivers/staging/gdm72xx/gdm_usb.c
@@ -635,11 +635,14 @@ static int gdm_usb_probe(struct usb_interface *intf,
 #endif /* CONFIG_WIMAX_GDM72XX_USB_PM */
 
 	ret = register_wimax_device(phy_dev, &intf->dev);
+	if (ret)
+		release_usb(udev);
 
 out:
 	if (ret) {
 		kfree(phy_dev);
 		kfree(udev);
+		usb_put_dev(usbdev);
 	} else {
 		usb_set_intfdata(intf, phy_dev);
 	}