From: Masahiro Yamada Date: Fri, 23 Nov 2018 07:57:21 +0000 (+0900) Subject: modpost: refactor seen flag clearing in add_depends() X-Git-Tag: for-linus-20190104~40^2~38 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=d2665ca8e3310d045b62397590ab54dc485e035e;p=linux-2.6-block.git modpost: refactor seen flag clearing in add_depends() You do not need to iterate over all modules for resetting ->seen flag because add_depends() is only interested in modules that export symbols referenced from the given 'mod'. This also avoids shadowing the 'modules' parameter of add_depends(). Signed-off-by: Masahiro Yamada --- diff --git a/scripts/mod/modpost.c b/scripts/mod/modpost.c index 3aab410f020e..eedc2742dc8e 100644 --- a/scripts/mod/modpost.c +++ b/scripts/mod/modpost.c @@ -2241,15 +2241,15 @@ static int add_versions(struct buffer *b, struct module *mod) return err; } -static void add_depends(struct buffer *b, struct module *mod, - struct module *modules) +static void add_depends(struct buffer *b, struct module *mod) { struct symbol *s; - struct module *m; int first = 1; - for (m = modules; m; m = m->next) - m->seen = is_vmlinux(m->name); + /* Clear ->seen flag of modules that own symbols needed by this. */ + for (s = mod->unres; s; s = s->next) + if (s->module) + s->module->seen = is_vmlinux(s->module->name); buf_printf(b, "\n"); buf_printf(b, "static const char __module_depends[]\n"); @@ -2518,7 +2518,7 @@ int main(int argc, char **argv) add_retpoline(&buf); add_staging_flag(&buf, mod->name); err |= add_versions(&buf, mod); - add_depends(&buf, mod, modules); + add_depends(&buf, mod); add_moddevtable(&buf, mod); add_srcversion(&buf, mod);