From: Vinod Koul <vkoul@kernel.org>
Date: Thu, 10 Mar 2022 04:43:20 +0000 (+0530)
Subject: dmaengine: Revert "dmaengine: shdma: Fix runtime PM imbalance on error"
X-Git-Tag: v5.18-rc1~56^2~12
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=d143f939a95696d38ff800ada14402fa50ebbd6c;p=linux-block.git

dmaengine: Revert "dmaengine: shdma: Fix runtime PM imbalance on error"

This reverts commit 455896c53d5b ("dmaengine: shdma: Fix runtime PM
imbalance on error") as the patch wrongly reduced the count on error and
did not bail out. So drop the count by reverting the patch .

Signed-off-by: Vinod Koul <vkoul@kernel.org>
---

diff --git a/drivers/dma/sh/shdma-base.c b/drivers/dma/sh/shdma-base.c
index b26ed690f03c..158e5e7defae 100644
--- a/drivers/dma/sh/shdma-base.c
+++ b/drivers/dma/sh/shdma-base.c
@@ -115,10 +115,8 @@ static dma_cookie_t shdma_tx_submit(struct dma_async_tx_descriptor *tx)
 		ret = pm_runtime_get(schan->dev);
 
 		spin_unlock_irq(&schan->chan_lock);
-		if (ret < 0) {
+		if (ret < 0)
 			dev_err(schan->dev, "%s(): GET = %d\n", __func__, ret);
-			pm_runtime_put(schan->dev);
-		}
 
 		pm_runtime_barrier(schan->dev);