From: Lukas Straub Date: Wed, 19 Jan 2022 21:14:30 +0000 (+0000) Subject: blktrace.c: Don't hardcode direct-io X-Git-Tag: fio-3.30~89 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=d0b12843fd441460bd9a0172169b028a74f76b10;p=fio.git blktrace.c: Don't hardcode direct-io This is unexpected if one wants to test performance of a standard filesystem (by pointing replay_redirect to a standard file) with buffered io. Signed-off-by: Lukas Straub Link: https://lore.kernel.org/r/239cc0c47c346408607772fb423aa5745a3779dd.1642626314.git.lukasstraub2@web.de Signed-off-by: Jens Axboe --- diff --git a/blktrace.c b/blktrace.c index f1dbd1a6..7682a4d5 100644 --- a/blktrace.c +++ b/blktrace.c @@ -582,14 +582,6 @@ bool read_blktrace(struct thread_data* td) td->o.max_bs[DDIR_TRIM] = rw_bs[DDIR_TRIM]; } - /* - * We need to do direct/raw ios to the device, to avoid getting - * read-ahead in our way. But only do so if the minimum block size - * is a multiple of 4k, otherwise we don't know if it's safe to do so. - */ - if (!fio_option_is_set(&td->o, odirect) && !(td_min_bs(td) & 4095)) - td->o.odirect = 1; - /* * If depth wasn't manually set, use probed depth */