From: Vincent Fu <vincent.fu@samsung.com>
Date: Wed, 17 Apr 2024 19:28:31 +0000 (-0400)
Subject: github: add reminders to PR template
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cf9c8b52a65139500729baaf8294a4bc953ae8d8;p=fio.git

github: add reminders to PR template

Remind contributors to bump the server version and ioengine ops version
when appropriate.

Signed-off-by: Vincent Fu <vincent.fu@samsung.com>
---

diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
index 4d98a694..6cead5b3 100644
--- a/.github/PULL_REQUEST_TEMPLATE.md
+++ b/.github/PULL_REQUEST_TEMPLATE.md
@@ -6,3 +6,10 @@ Please confirm that your commit message(s) follow these guidelines:
    aren't something like a URL at 72-74 chars.
 4. Empty line
 5. Signed-off-by: Real Name <real@email.com>
+
+Reminders:
+
+1. If you modify struct thread_options, also make corresponding changes in
+   cconv.c and bump FIO_SERVER_VER in server.h
+2. If you change the ioengine interface (hooks, flags, etc), remember to bump
+   FIO_IOOPS_VERSION in ioengines.h.