From: Hangyu Hua <hbh25y@gmail.com>
Date: Fri, 27 Oct 2023 03:03:02 +0000 (+0800)
Subject: 9p/net: fix possible memory leak in p9_check_errors()
X-Git-Tag: block-6.7-2023-11-10~15^2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ce07087964208eee2ca2f9ee4a98f8b5d9027fe6;p=linux-block.git

9p/net: fix possible memory leak in p9_check_errors()

When p9pdu_readf() is called with "s?d" attribute, it allocates a pointer
that will store a string. But when p9pdu_readf() fails while handling "d"
then this pointer will not be freed in p9_check_errors().

Fixes: 51a87c552dfd ("9p: rework client code to use new protocol support functions")
Reviewed-by: Christian Schoenebeck <linux_oss@crudebyte.com>
Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Message-ID: <20231027030302.11927-1-hbh25y@gmail.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
---

diff --git a/net/9p/client.c b/net/9p/client.c
index 9c2bc15e3cfa..e265a0ca6bdd 100644
--- a/net/9p/client.c
+++ b/net/9p/client.c
@@ -540,12 +540,14 @@ static int p9_check_errors(struct p9_client *c, struct p9_req_t *req)
 		return 0;
 
 	if (!p9_is_proto_dotl(c)) {
-		char *ename;
+		char *ename = NULL;
 
 		err = p9pdu_readf(&req->rc, c->proto_version, "s?d",
 				  &ename, &ecode);
-		if (err)
+		if (err) {
+			kfree(ename);
 			goto out_err;
+		}
 
 		if (p9_is_proto_dotu(c) && ecode < 512)
 			err = -ecode;