From: Dave Jiang Date: Fri, 4 Apr 2025 16:54:18 +0000 (-0700) Subject: cxl: Remove always true condition for cxlctl_validate_hw_command() X-Git-Tag: v6.16-rc1~60^2~15 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cdafa67c0270116b0f4cdbd00b6170eb9aa92edf;p=linux-block.git cxl: Remove always true condition for cxlctl_validate_hw_command() smatch warnings: drivers/cxl/core/features.c:441 cxlctl_validate_hw_command() warn: always true condition '(scope >= 0) => (0-u32max >= 0)' Remove the check entirely as it has no effect. Expectation is both of these operations should be allowed for all check levels. They are read only and have no change effects. Reported-by: kernel test robot Closes: https://lore.kernel.org/oe-kbuild-all/202504041033.2HBboAZR-lkp@intel.com/ Reviewed-by: Li Ming Reviewed-by: Ira Weiny Reviewed-by: Jonathan Cameron Link: https://patch.msgid.link/20250404165418.3032414-1-dave.jiang@intel.com Signed-off-by: Dave Jiang --- diff --git a/drivers/cxl/core/features.c b/drivers/cxl/core/features.c index 1498e2369c37..bdc2c492bdff 100644 --- a/drivers/cxl/core/features.c +++ b/drivers/cxl/core/features.c @@ -614,11 +614,7 @@ static bool cxlctl_validate_hw_command(struct cxl_features_state *cxlfs, switch (opcode) { case CXL_MBOX_OP_GET_SUPPORTED_FEATURES: case CXL_MBOX_OP_GET_FEATURE: - if (cxl_mbox->feat_cap < CXL_FEATURES_RO) - return false; - if (scope >= FWCTL_RPC_CONFIGURATION) - return true; - return false; + return cxl_mbox->feat_cap >= CXL_FEATURES_RO; case CXL_MBOX_OP_SET_FEATURE: if (cxl_mbox->feat_cap < CXL_FEATURES_RW) return false;