From: Barry Song Date: Wed, 21 Feb 2024 08:50:36 +0000 (+1300) Subject: madvise:madvise_cold_or_pageout_pte_range(): allow split while folio_estimated_sharer... X-Git-Tag: v6.9-rc1~107^2~128 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cc864ebba5f612ce2960e7e09322a193e8fda0d7;p=linux-2.6-block.git madvise:madvise_cold_or_pageout_pte_range(): allow split while folio_estimated_sharers = 0 The purpose is stopping splitting large folios whose mapcount are 2 or above. Folios whose estimated_shares = 0 should be still perfect and even better candidates than estimated_shares = 1. Consider a pte-mapped large folio with 16 subpages, if we unmap 1-15, the current code will split folios and reclaim them while madvise goes on this folio; but if we unmap subpage 0, we will keep this folio and break. This is weird. For pmd-mapped large folios, we can still use "= 1" as the condition as anyway we have the entire map for it. So this patch doesn't change the condition for pmd-mapped large folios. This also explains why we had been using "= 1" for both pmd-mapped and pte-mapped large folios before commit 07e8c82b5eff ("madvise: convert madvise_cold_or_pageout_pte_range() to use folios"), because in the past, we used the mapcount of the specific subpage, since the subpage had pte present, its mapcount wouldn't be 0. The problem can be quite easily reproduced by writing a small program, unmapping the first subpage of a pte-mapped large folio vs. unmapping anyone other than the first subpage. Link: https://lkml.kernel.org/r/20240221085036.105621-1-21cnbao@gmail.com Fixes: 2f406263e3e9 ("madvise:madvise_cold_or_pageout_pte_range(): don't use mapcount() against large folio for sharing check") Signed-off-by: Barry Song Reviewed-by: David Hildenbrand Reviewed-by: Vishal Moola (Oracle) Cc: Yin Fengwei Cc: Yu Zhao Cc: Ryan Roberts Cc: Kefeng Wang Cc: Matthew Wilcox Cc: Minchan Kim Cc: Yang Shi Signed-off-by: Andrew Morton --- diff --git a/mm/madvise.c b/mm/madvise.c index cfa5e7288261..abde3edb04f0 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -453,7 +453,7 @@ restart: if (folio_test_large(folio)) { int err; - if (folio_estimated_sharers(folio) != 1) + if (folio_estimated_sharers(folio) > 1) break; if (pageout_anon_only_filter && !folio_test_anon(folio)) break;