From: Dan Carpenter Date: Fri, 20 May 2022 15:02:39 +0000 (+0300) Subject: thermal/drivers/k3_j72xx_bandgap: Fix array underflow in prep_lookup_table() X-Git-Tag: for-5.20/block-2022-08-04~142^2^2~20 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cc67ca28cf8b29245b71e01117927ed2793f35b7;p=linux-block.git thermal/drivers/k3_j72xx_bandgap: Fix array underflow in prep_lookup_table() This while loop exits with "i" set to -1 and so then it sets: derived_table[-1] = derived_table[0] - 300; There is no need for this assignment at all. Just delete it. Fixes: 72b3fc61c752 ("thermal: k3_j72xx_bandgap: Add the bandgap driver support") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/YoetjwcOEzYEFp9b@kili Signed-off-by: Daniel Lezcano --- diff --git a/drivers/thermal/k3_j72xx_bandgap.c b/drivers/thermal/k3_j72xx_bandgap.c index 3a35aa38ff51..27d4cae44aa7 100644 --- a/drivers/thermal/k3_j72xx_bandgap.c +++ b/drivers/thermal/k3_j72xx_bandgap.c @@ -151,8 +151,6 @@ static int prep_lookup_table(struct err_values *err_vals, int *ref_table) /* 300 milli celsius steps */ while (i--) derived_table[i] = derived_table[i + 1] - 300; - /* case 0 */ - derived_table[i] = derived_table[i + 1] - 300; } /*