From: Wei Yongjun <weiyongjun1@huawei.com>
Date: Sat, 29 Jan 2022 01:27:02 +0000 (+0000)
Subject: net/fsl: xgmac_mdio: fix return value check in xgmac_mdio_probe()
X-Git-Tag: v5.18-rc1~136^2~487
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cc4598cf179ff636d7634008045905a88480bb88;p=linux-block.git

net/fsl: xgmac_mdio: fix return value check in xgmac_mdio_probe()

In case of error, the function devm_ioremap() returns NULL pointer
not ERR_PTR(). The IS_ERR() test in the return value check should
be replaced with NULL test.

Fixes: 1d14eb15dc2c ("net/fsl: xgmac_mdio: Use managed device resources")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Tobias Waldekranz <tobias@waldekranz.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/ethernet/freescale/xgmac_mdio.c b/drivers/net/ethernet/freescale/xgmac_mdio.c
index 2243c8fcdee1..ef8058a17188 100644
--- a/drivers/net/ethernet/freescale/xgmac_mdio.c
+++ b/drivers/net/ethernet/freescale/xgmac_mdio.c
@@ -335,8 +335,8 @@ static int xgmac_mdio_probe(struct platform_device *pdev)
 	priv = bus->priv;
 	priv->mdio_base = devm_ioremap(&pdev->dev, res->start,
 				       resource_size(res));
-	if (IS_ERR(priv->mdio_base))
-		return PTR_ERR(priv->mdio_base);
+	if (!priv->mdio_base)
+		return -ENOMEM;
 
 	/* For both ACPI and DT cases, endianness of MDIO controller
 	 * needs to be specified using "little-endian" property.