From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 22 Jun 2021 13:08:52 +0000 (+0300)
Subject: mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()
X-Git-Tag: block-5.14-2021-07-08~40^2~10
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cc3eb51814d0f31671d57e85d4912403a11506e9;p=linux-block.git

mailbox: mtk-cmdq: Fix uninitialized variable in cmdq_mbox_flush()

The "cb" pointer needs to be initialized before can assign
"data.data = cb->data;".

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---

diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c b/drivers/mailbox/mtk-cmdq-mailbox.c
index 301e65b9527a..67a42b514429 100644
--- a/drivers/mailbox/mtk-cmdq-mailbox.c
+++ b/drivers/mailbox/mtk-cmdq-mailbox.c
@@ -455,10 +455,10 @@ static int cmdq_mbox_flush(struct mbox_chan *chan, unsigned long timeout)
 
 	list_for_each_entry_safe(task, tmp, &thread->task_busy_list,
 				 list_entry) {
+		cb = &task->pkt->async_cb;
 		data.sta = -ECONNABORTED;
 		data.data = cb->data;
 		data.pkt = task->pkt;
-		cb = &task->pkt->async_cb;
 		if (cb->cb)
 			cb->cb(data);