From: Ian Abbott Date: Tue, 15 Apr 2025 11:35:56 +0000 (+0100) Subject: comedi: ni_pcidio: Do not bother filling buffer with 0xaa byte values X-Git-Tag: v6.16-rc1~30^2~66 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=cb0dde4d058b1fe7fc80d851b16c6687f461214b;p=linux-block.git comedi: ni_pcidio: Do not bother filling buffer with 0xaa byte values On buffer change, the driver informs the mite module about the buffer change and then it fills the buffer with byte value `0xaa` using `memset()`. Do not bother filling the buffer. None of the other Comedi drivers do this. The aim is to get rid of the `prealloc_buf` member of `struct comedi_async` (which is from a `vmap()` covering the whole buffer in those Comedi drivers that do not use DMA), and use the per-buffer-page addresses from the `virt_addr` member of `struct comedi_buf_page` to access the buffer contents instead. (If necessary, we could add a `comedi_buf_memset()` function to fill the buffer with a byte value, but it's not worth it in this case.) Signed-off-by: Ian Abbott Link: https://lore.kernel.org/r/20250415114008.5977-2-abbotti@mev.co.uk Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/comedi/drivers/ni_pcidio.c b/drivers/comedi/drivers/ni_pcidio.c index 2d58e83420e8..2c7bb9c1ea5b 100644 --- a/drivers/comedi/drivers/ni_pcidio.c +++ b/drivers/comedi/drivers/ni_pcidio.c @@ -747,8 +747,6 @@ static int ni_pcidio_change(struct comedi_device *dev, if (ret < 0) return ret; - memset(s->async->prealloc_buf, 0xaa, s->async->prealloc_bufsz); - return 0; }