From: Trond Myklebust <trond.myklebust@hammerspace.com>
Date: Tue, 25 Mar 2025 00:03:03 +0000 (-0400)
Subject: NFSv4: clp->cl_cons_state < 0 signifies an invalid nfs_client
X-Git-Tag: v6.15-rc1~50^2~5
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c81d5bcb7b38ab0322aea93152c091451b82d3f3;p=linux-block.git

NFSv4: clp->cl_cons_state < 0 signifies an invalid nfs_client

If someone calls nfs_mark_client_ready(clp, status) with a negative
value for status, then that should signal that the nfs_client is no
longer valid.

Reviewed-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---

diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c
index f1f7eaa97973..272d2ebdae0f 100644
--- a/fs/nfs/nfs4state.c
+++ b/fs/nfs/nfs4state.c
@@ -1403,7 +1403,7 @@ int nfs4_schedule_stateid_recovery(const struct nfs_server *server, struct nfs4_
 	dprintk("%s: scheduling stateid recovery for server %s\n", __func__,
 			clp->cl_hostname);
 	nfs4_schedule_state_manager(clp);
-	return 0;
+	return clp->cl_cons_state < 0 ? clp->cl_cons_state : 0;
 }
 EXPORT_SYMBOL_GPL(nfs4_schedule_stateid_recovery);