From: Ilpo Järvinen Date: Mon, 16 Dec 2024 17:56:24 +0000 (+0200) Subject: PCI: Remove incorrect comment from pci_reassign_resource() X-Git-Tag: block-6.15-20250403~40^2~22^2~19 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c8098ad8fb2e80dcb92920da795455d30ed5e292;p=linux-block.git PCI: Remove incorrect comment from pci_reassign_resource() Commit a4ac9fea016f ("PCI : Calculate right add_size") removed including min_align into new_size in pci_reassign_resource() which is the correct thing to do. However, it also added a snakeoil comment that the resource would already be aligned with min_align which is incorrect. A resource that is assigned earlier is aligned with the old alignment, NOT with the new requested alignment (min_align) until later deep within the reassignment callchain. Thus, remove the incorrect comment. Link: https://lore.kernel.org/r/20241216175632.4175-18-ilpo.jarvinen@linux.intel.com Signed-off-by: Ilpo Järvinen Signed-off-by: Bjorn Helgaas Tested-by: Xiaochun Lee Cc: Yinghai Lu --- diff --git a/drivers/pci/setup-res.c b/drivers/pci/setup-res.c index 83ffff7cc0a3..51ff9ab1f400 100644 --- a/drivers/pci/setup-res.c +++ b/drivers/pci/setup-res.c @@ -387,7 +387,6 @@ int pci_reassign_resource(struct pci_dev *dev, int resno, return -EINVAL; } - /* already aligned with min_align */ new_size = resource_size(res) + addsize; ret = _pci_assign_resource(dev, resno, new_size, min_align); if (ret) {