From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 18 Oct 2017 07:48:25 +0000 (+0300)
Subject: tipc: checking for NULL instead of IS_ERR()
X-Git-Tag: v4.15-rc1~84^2~397
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c75e427d9349ec3e0059752cc784e1c301474c2d;p=linux-block.git

tipc: checking for NULL instead of IS_ERR()

The tipc_alloc_conn() function never returns NULL, it returns error
pointers, so I have fixed the check.

Fixes: 14c04493cb77 ("tipc: add ability to order and receive topology events in driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/net/tipc/server.c b/net/tipc/server.c
index 713077536d0c..acaef80fb88c 100644
--- a/net/tipc/server.c
+++ b/net/tipc/server.c
@@ -504,7 +504,7 @@ bool tipc_topsrv_kern_subscr(struct net *net, u32 port, u32 type,
 	*(u32 *)&sub.usr_handle = port;
 
 	con = tipc_alloc_conn(tipc_topsrv(net));
-	if (!con)
+	if (IS_ERR(con))
 		return false;
 
 	*conid = con->conid;