From: Dan Carpenter Date: Thu, 21 Jan 2021 06:08:41 +0000 (+0300) Subject: scsi: qla2xxx: Remove unnecessary NULL check X-Git-Tag: v5.12-rc1-dontuse~5^2~53 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c750a9c9c59a85843d447910a27da21c5bcf600a;p=linux-2.6-block.git scsi: qla2xxx: Remove unnecessary NULL check The list iterator can't be NULL so this check is not required. Removing the check silences a Smatch warning about inconsistent NULL checking. drivers/scsi/qla2xxx/qla_dfs.c:371 qla_dfs_tgt_counters_show() error: we previously assumed 'fcport' could be null (see line 372) Link: https://lore.kernel.org/r/YAkaaSrhn1mFqyHy@mwanda Acked-by: Saurav Kashyap Signed-off-by: Dan Carpenter Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/qla2xxx/qla_dfs.c b/drivers/scsi/qla2xxx/qla_dfs.c index ccce0eab844e..85bd0e468d43 100644 --- a/drivers/scsi/qla2xxx/qla_dfs.c +++ b/drivers/scsi/qla2xxx/qla_dfs.c @@ -369,7 +369,7 @@ qla_dfs_tgt_counters_show(struct seq_file *s, void *unused) seq_puts(s, "\n"); list_for_each_entry(fcport, &vha->vp_fcports, list) { - if (!fcport || !fcport->rport) + if (!fcport->rport) continue; seq_printf(s, "Target Num = %7d Link Down Count = %14lld\n",