From: Erick Archer <erick.archer@outlook.com>
Date: Sat, 18 May 2024 08:30:39 +0000 (+0200)
Subject: Bluetooth: hci_core: Prefer array indexing over pointer arithmetic
X-Git-Tag: io_uring-6.11-20240722~71^2~12^2~53
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c61e41121036aa610e904ef60f8520e10455ee8c;p=linux-block.git

Bluetooth: hci_core: Prefer array indexing over pointer arithmetic

Refactor the list_for_each_entry() loop of hci_get_dev_list()
function to use array indexing instead of pointer arithmetic.

This way, the code is more readable and idiomatic.

Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Erick Archer <erick.archer@outlook.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---

diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index a2cad8a982f6..55bdc365916f 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -828,8 +828,8 @@ int hci_get_dev_list(void __user *arg)
 		if (hci_dev_test_flag(hdev, HCI_AUTO_OFF))
 			flags &= ~BIT(HCI_UP);
 
-		(dr + n)->dev_id  = hdev->id;
-		(dr + n)->dev_opt = flags;
+		dr[n].dev_id  = hdev->id;
+		dr[n].dev_opt = flags;
 
 		if (++n >= dev_num)
 			break;