From: Markus Elfring Date: Mon, 17 Nov 2014 12:04:14 +0000 (+0100) Subject: ALSA: hdsp: Deletion of an unnecessary check before the function call "release_firmware" X-Git-Tag: v3.19-rc1~11^2~39^2~55 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c283661018e347bc72633969411974df8ec2ac92;p=linux-block.git ALSA: hdsp: Deletion of an unnecessary check before the function call "release_firmware" The release_firmware() function tests whether its argument is NULL and then return immediately. Thus the test around the call is not needed. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring Signed-off-by: Takashi Iwai --- diff --git a/sound/pci/rme9652/hdsp.c b/sound/pci/rme9652/hdsp.c index 2eb8baf7b828..cf5a6c8b9a63 100644 --- a/sound/pci/rme9652/hdsp.c +++ b/sound/pci/rme9652/hdsp.c @@ -5307,8 +5307,7 @@ static int snd_hdsp_free(struct hdsp *hdsp) snd_hdsp_free_buffers(hdsp); - if (hdsp->firmware) - release_firmware(hdsp->firmware); + release_firmware(hdsp->firmware); vfree(hdsp->fw_uploaded); if (hdsp->iobase)