From: Lucas De Marchi Date: Mon, 9 Dec 2024 23:27:38 +0000 (-0800) Subject: drm/xe/reg_sr: Stop setting all whitelist slots X-Git-Tag: block-6.14-20240131~40^2~17^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c1151691b5e97b600a9ef3efd7c31a3abf568e41;p=linux-block.git drm/xe/reg_sr: Stop setting all whitelist slots Currently xe_reg_sr_apply_whitelist() sets the unused values to a known used value for no good reason: it could just leave it with the HW default. The behavior is slightly different if there are no whitelist registers for the engine as the function returns early. This is not needed, so just drop the addition writes for the unused slots. Later this will allow to reduce the amount of registers passed to GuC for save/restore. Reviewed-by: Matt Roper Link: https://patchwork.freedesktop.org/patch/msgid/20241209232739.147417-5-lucas.demarchi@intel.com Signed-off-by: Lucas De Marchi --- diff --git a/drivers/gpu/drm/xe/xe_reg_sr.c b/drivers/gpu/drm/xe/xe_reg_sr.c index 080229e0fc15..0a5c0e62d6e8 100644 --- a/drivers/gpu/drm/xe/xe_reg_sr.c +++ b/drivers/gpu/drm/xe/xe_reg_sr.c @@ -227,13 +227,6 @@ void xe_reg_sr_apply_whitelist(struct xe_hw_engine *hwe) slot++; } - /* And clear the rest just in case of garbage */ - for (; slot < RING_MAX_NONPRIV_SLOTS; slot++) { - u32 addr = RING_NOPID(mmio_base).addr; - - xe_mmio_write32(>->mmio, RING_FORCE_TO_NONPRIV(mmio_base, slot), addr); - } - xe_force_wake_put(gt_to_fw(gt), fw_ref); return;