From: David S. Miller Date: Mon, 24 Feb 2020 22:40:54 +0000 (-0800) Subject: bareudp: Fix uninitialized variable warnings. X-Git-Tag: block-5.7-2020-04-09~9^2~338 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c102b6fddcab89cc6a17c43f8b731e2c9f29b88a;p=linux-2.6-block.git bareudp: Fix uninitialized variable warnings. drivers/net/bareudp.c: In function 'bareudp_xmit_skb': drivers/net/bareudp.c:346:9: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] 346 | return err; | ^~~ drivers/net/bareudp.c: In function 'bareudp6_xmit_skb': drivers/net/bareudp.c:407:9: warning: 'err' may be used uninitialized in this function [-Wmaybe-uninitialized] 407 | return err; Reported-by: Stephen Rothwell Signed-off-by: David S. Miller --- diff --git a/drivers/net/bareudp.c b/drivers/net/bareudp.c index 77e72477499d..15337e9d4fad 100644 --- a/drivers/net/bareudp.c +++ b/drivers/net/bareudp.c @@ -320,6 +320,7 @@ static int bareudp_xmit_skb(struct sk_buff *skb, struct net_device *dev, df = key->tun_flags & TUNNEL_DONT_FRAGMENT ? htons(IP_DF) : 0; skb_scrub_packet(skb, xnet); + err = -ENOSPC; if (!skb_pull(skb, skb_network_offset(skb))) goto free_dst; @@ -381,6 +382,7 @@ static int bareudp6_xmit_skb(struct sk_buff *skb, struct net_device *dev, skb_scrub_packet(skb, xnet); + err = -ENOSPC; if (!skb_pull(skb, skb_network_offset(skb))) goto free_dst;