From: Zhang Qilong Date: Tue, 3 Nov 2020 14:09:10 +0000 (+0800) Subject: spi: spi-mem: fix reference leak in spi_mem_access_start X-Git-Tag: io_uring-5.11-2020-12-23~68^2^2~52 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=c02bb16b0e826bf0e19aa42c3ae60ea339f32cf5;p=linux-block.git spi: spi-mem: fix reference leak in spi_mem_access_start pm_runtime_get_sync will increment pm usage counter even it failed. Forgetting to pm_runtime_put_noidle will result in reference leak in spi_mem_access_start, so we should fix it. Fixes: f86c24f479530 ("spi: spi-mem: Split spi_mem_exec_op() code") Signed-off-by: Zhang Qilong Link: https://lore.kernel.org/r/20201103140910.3482-1-zhangqilong3@huawei.com Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c index a1b4d085834a..f3a3f196e628 100644 --- a/drivers/spi/spi-mem.c +++ b/drivers/spi/spi-mem.c @@ -243,6 +243,7 @@ static int spi_mem_access_start(struct spi_mem *mem) ret = pm_runtime_get_sync(ctlr->dev.parent); if (ret < 0) { + pm_runtime_put_noidle(ctlr->dev.parent); dev_err(&ctlr->dev, "Failed to power device: %d\n", ret); return ret;