From: Oleksij Rempel Date: Mon, 9 Dec 2024 13:07:46 +0000 (+0100) Subject: net: usb: lan78xx: Fix return value handling in lan78xx_set_features X-Git-Tag: block-6.14-20240131~28^2~245^2~2 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=bf361b18d91e96dee50c5794097a80ff3594725c;p=linux-block.git net: usb: lan78xx: Fix return value handling in lan78xx_set_features Update `lan78xx_set_features` to correctly return the result of `lan78xx_write_reg`. This ensures that errors during register writes are propagated to the caller. Signed-off-by: Oleksij Rempel Reviewed-by: Andrew Lunn Link: https://patch.msgid.link/20241209130751.703182-7-o.rempel@pengutronix.de Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c index 442b6ee2dd46..71f8176210c9 100644 --- a/drivers/net/usb/lan78xx.c +++ b/drivers/net/usb/lan78xx.c @@ -2822,9 +2822,7 @@ static int lan78xx_set_features(struct net_device *netdev, spin_unlock_irqrestore(&pdata->rfe_ctl_lock, flags); - lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); - - return 0; + return lan78xx_write_reg(dev, RFE_CTL, pdata->rfe_ctl); } static void lan78xx_deferred_vlan_write(struct work_struct *param)