From: Hangyu Hua <hbh25y@gmail.com>
Date: Thu, 9 Dec 2021 08:28:39 +0000 (+0800)
Subject: phonet: refcount leak in pep_sock_accep
X-Git-Tag: v5.16-rc6~24^2~40
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=bcd0f93353326954817a4f9fa55ec57fb38acbb0;p=linux-block.git

phonet: refcount leak in pep_sock_accep

sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/phonet/pep.c b/net/phonet/pep.c
index a1525916885a..b4f90afb0638 100644
--- a/net/phonet/pep.c
+++ b/net/phonet/pep.c
@@ -868,6 +868,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,
 
 	err = pep_accept_conn(newsk, skb);
 	if (err) {
+		__sock_put(sk);
 		sock_put(newsk);
 		newsk = NULL;
 		goto drop;