From: Jules Irenge Date: Sat, 11 Apr 2020 00:19:31 +0000 (+0100) Subject: scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() X-Git-Tag: v5.8-rc1~8^2~177 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=bc834e074e36262d62a9e26742ed5a5246a469eb;p=linux-block.git scsi: bnx2fc: Add missing annotation for bnx2fc_abts_cleanup() Sparse reports the following warning: warning: context imbalance in bnx2fc_abts_cleanup() - unexpected unlock The root cause is the missing annotation at bnx2fc_abts_cleanup(). Add the missing __must_hold(&tgt->tgt_lock) annotation. Link: https://lore.kernel.org/r/20200411001933.10072-8-jbi.octave@gmail.com Signed-off-by: Jules Irenge Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/bnx2fc/bnx2fc_io.c b/drivers/scsi/bnx2fc/bnx2fc_io.c index 2b070f0835df..1aba5897ccb0 100644 --- a/drivers/scsi/bnx2fc/bnx2fc_io.c +++ b/drivers/scsi/bnx2fc/bnx2fc_io.c @@ -1081,6 +1081,7 @@ int bnx2fc_eh_device_reset(struct scsi_cmnd *sc_cmd) } static int bnx2fc_abts_cleanup(struct bnx2fc_cmd *io_req) + __must_hold(&tgt->tgt_lock) { struct bnx2fc_rport *tgt = io_req->tgt; unsigned int time_left;