From: Al Viro <viro@zeniv.linux.org.uk>
Date: Fri, 31 May 2024 03:58:26 +0000 (-0400)
Subject: lirc: rc_dev_get_from_fd(): fix file leak
X-Git-Tag: v6.11-rc1~38^2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=bba1f6758a9ec90c1adac5dcf78f8a15f1bad65b;p=linux-block.git

lirc: rc_dev_get_from_fd(): fix file leak

missing fdput() on a failure exit

Fixes: 6a9d552483d50 "media: rc: bpf attach/detach requires write permission" # v6.9
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c
index 52aea4167718..717c441b4a86 100644
--- a/drivers/media/rc/lirc_dev.c
+++ b/drivers/media/rc/lirc_dev.c
@@ -828,8 +828,10 @@ struct rc_dev *rc_dev_get_from_fd(int fd, bool write)
 		return ERR_PTR(-EINVAL);
 	}
 
-	if (write && !(f.file->f_mode & FMODE_WRITE))
+	if (write && !(f.file->f_mode & FMODE_WRITE)) {
+		fdput(f);
 		return ERR_PTR(-EPERM);
+	}
 
 	fh = f.file->private_data;
 	dev = fh->rc;