From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Date: Sat, 12 Aug 2023 18:57:48 +0000 (+0200)
Subject: gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim()
X-Git-Tag: block-6.6-2023-09-08~24^2~17
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ba0294df2dbdc006ffbf037da28bba64e9f6d709;p=linux-block.git

gpio: sim: replace memmove() + strstrip() with skip_spaces() + strim()

Turns out we can avoid the memmove() by using skip_spaces() and strim().
We did that in gpio-consumer, let's do it in gpio-sim.

Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---

diff --git a/drivers/gpio/gpio-sim.c b/drivers/gpio/gpio-sim.c
index 1fbbb49985f6..b7161c83c104 100644
--- a/drivers/gpio/gpio-sim.c
+++ b/drivers/gpio/gpio-sim.c
@@ -642,16 +642,13 @@ static bool gpio_sim_device_is_live_unlocked(struct gpio_sim_device *dev)
 
 static char *gpio_sim_strdup_trimmed(const char *str, size_t count)
 {
-	char *dup, *trimmed;
+	char *trimmed;
 
-	dup = kstrndup(str, count, GFP_KERNEL);
-	if (!dup)
+	trimmed = kstrndup(skip_spaces(str), count, GFP_KERNEL);
+	if (!trimmed)
 		return NULL;
 
-	trimmed = strstrip(dup);
-	memmove(dup, trimmed, strlen(trimmed) + 1);
-
-	return dup;
+	return strim(trimmed);
 }
 
 static ssize_t gpio_sim_device_config_dev_name_show(struct config_item *item,