From: Josef Bacik <josef@toxicpanda.com>
Date: Mon, 19 May 2025 18:03:01 +0000 (-0400)
Subject: btrfs: don't drop a reference if btrfs_check_write_meta_pointer() fails
X-Git-Tag: v6.16-rc1~143^2
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=b83825a8f56a34e7352e424aae64ffe6b88247d1;p=linux-2.6-block.git

btrfs: don't drop a reference if btrfs_check_write_meta_pointer() fails

In the zoned mode there's a bug in the extent buffer tree conversion to
xarray. The reference for eb is dropped and code continues but the
references get dropped by releasing the batch.

Reported-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reported-by: kernel test robot <oliver.sang@intel.com>
Link: https://lore.kernel.org/linux-btrfs/202505191521.435b97ac-lkp@intel.com/
Fixes: 19d7f65f032f ("btrfs: convert the buffer_radix to an xarray")
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Tested-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c
index e43f6280f954..849199768664 100644
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@ -2189,7 +2189,6 @@ retry:
 					done = 1;
 					break;
 				}
-				free_extent_buffer(eb);
 				continue;
 			}