From: Colin Ian King Date: Wed, 9 Jun 2021 17:43:53 +0000 (+0100) Subject: net: dsa: sja1105: Fix assigned yet unused return code rc X-Git-Tag: io_uring-5.14-2021-07-09~10^2~242 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=ab324d8dfddad04bec0e8421242716504e31e204;p=linux-block.git net: dsa: sja1105: Fix assigned yet unused return code rc The return code variable rc is being set to return error values in two places in sja1105_mdiobus_base_tx_register and yet it is not being returned, the function always returns 0 instead. Fix this by replacing the return 0 with the return code rc. Addresses-Coverity: ("Unused value") Fixes: 5a8f09748ee7 ("net: dsa: sja1105: register the MDIO buses for 100base-T1 and 100base-TX") Signed-off-by: Colin Ian King Reviewed-by: Vladimir Oltean Signed-off-by: David S. Miller --- diff --git a/drivers/net/dsa/sja1105/sja1105_mdio.c b/drivers/net/dsa/sja1105/sja1105_mdio.c index 8dfd06318b23..08517c70cb48 100644 --- a/drivers/net/dsa/sja1105/sja1105_mdio.c +++ b/drivers/net/dsa/sja1105/sja1105_mdio.c @@ -171,7 +171,7 @@ static int sja1105_mdiobus_base_tx_register(struct sja1105_private *priv, out_put_np: of_node_put(np); - return 0; + return rc; } static void sja1105_mdiobus_base_tx_unregister(struct sja1105_private *priv)