From: Ankit Kumar Date: Mon, 14 Aug 2023 14:57:38 +0000 (+0530) Subject: engines:io_uring: add missing error during open file X-Git-Tag: fio-3.36~31 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=a904d1829b058506bdb9cf6c223f45260a30e723;hp=62f35562722f0c903567096d0f10a836d1ae2f60;p=fio.git engines:io_uring: add missing error during open file This change ensures the error is propogated to upper layers to make fio exit with a non-zero return code. Add filename for errors when block size is not a multiple of logical blocks. Signed-off-by: Ankit Kumar Link: https://lore.kernel.org/r/20230814145747.114725-2-ankit.kumar@samsung.com Signed-off-by: Vincent Fu --- diff --git a/engines/io_uring.c b/engines/io_uring.c index b361e6a5..09065463 100644 --- a/engines/io_uring.c +++ b/engines/io_uring.c @@ -1115,10 +1115,12 @@ static int fio_ioring_cmd_open_file(struct thread_data *td, struct fio_file *f) if (td->o.min_bs[ddir] % lba_size || td->o.max_bs[ddir] % lba_size) { if (data->lba_ext) - log_err("block size must be a multiple of " - "(LBA data size + Metadata size)\n"); + log_err("%s: block size must be a multiple of (LBA data size + Metadata size)\n", + f->file_name); else - log_err("block size must be a multiple of LBA data size\n"); + log_err("%s: block size must be a multiple of LBA data size\n", + f->file_name); + td_verror(td, EINVAL, "fio_ioring_cmd_open_file"); return 1; } }