From: Arend Van Spriel Date: Mon, 19 Feb 2018 23:14:21 +0000 (+0100) Subject: brcmfmac: usb: call brcmf_usb_up() during brcmf_bus_preinit() X-Git-Tag: for-linus-20180413~64^2~101^2~39 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=a7f4a80c0070b673d4a4ce94b99979ea6d0c6296;p=linux-block.git brcmfmac: usb: call brcmf_usb_up() during brcmf_bus_preinit() By calling brcmf_usb_up() during brcmf_bus_preinit() it does not need to be called in brcmf_usb_bus_setup(). Reviewed-by: Hante Meuleman Reviewed-by: Pieter-Paul Giesberts Reviewed-by: Franky Lin Signed-off-by: Arend van Spriel Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c index b27170c12482..d22cd1662da6 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/usb.c @@ -1146,8 +1146,9 @@ static int brcmf_usb_get_fwname(struct device *dev, u32 chip, u32 chiprev, } static const struct brcmf_bus_ops brcmf_usb_bus_ops = { - .txdata = brcmf_usb_tx, + .preinit = brcmf_usb_up, .stop = brcmf_usb_down, + .txdata = brcmf_usb_tx, .txctl = brcmf_usb_tx_ctlpkt, .rxctl = brcmf_usb_rx_ctlpkt, .wowl_config = brcmf_usb_wowl_config, @@ -1165,10 +1166,6 @@ static int brcmf_usb_bus_setup(struct brcmf_usbdev_info *devinfo) return ret; } - ret = brcmf_usb_up(devinfo->dev); - if (ret) - goto fail; - ret = brcmf_bus_started(devinfo->dev); if (ret) goto fail;