From: Alex Dewar Date: Mon, 14 Sep 2020 17:57:01 +0000 (+0100) Subject: fs: omfs: use kmemdup() rather than kmalloc+memcpy X-Git-Tag: v5.10-rc1~19^2~5 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=a7c9df0446d295daee68bb16c9b3746f3d21b1ef;p=linux-2.6-block.git fs: omfs: use kmemdup() rather than kmalloc+memcpy Issue identified with Coccinelle. Signed-off-by: Alex Dewar Acked-by: Bob Copeland Signed-off-by: Al Viro --- diff --git a/fs/omfs/inode.c b/fs/omfs/inode.c index 68aa38a48308..ce93ccca8639 100644 --- a/fs/omfs/inode.c +++ b/fs/omfs/inode.c @@ -362,12 +362,11 @@ static int omfs_get_imap(struct super_block *sb) bh = sb_bread(sb, block++); if (!bh) goto nomem_free; - *ptr = kmalloc(sb->s_blocksize, GFP_KERNEL); + *ptr = kmemdup(bh->b_data, sb->s_blocksize, GFP_KERNEL); if (!*ptr) { brelse(bh); goto nomem_free; } - memcpy(*ptr, bh->b_data, sb->s_blocksize); if (count < sb->s_blocksize) memset((void *)*ptr + count, 0xff, sb->s_blocksize - count);