From: Harvey Harrison Date: Wed, 22 Oct 2008 03:27:16 +0000 (-0700) Subject: staging: correct dubious use of !x & y X-Git-Tag: v2.6.29-rc1~228^2~233 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=a3379572474aad4d113985682971955ad87c8a37;p=linux-2.6-block.git staging: correct dubious use of !x & y Noticed by sparse: drivers/staging/me4000/me4000.c:1213:43: warning: dubious: !x & y drivers/staging/wlan-ng/p80211wext.c:1583:21: warning: dubious: !x & y Signed-off-by: Harvey Harrison Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/me4000/me4000.c b/drivers/staging/me4000/me4000.c index 0394e2709278..0ac04b7f34bb 100644 --- a/drivers/staging/me4000/me4000.c +++ b/drivers/staging/me4000/me4000.c @@ -1180,7 +1180,7 @@ static int me4000_xilinx_download(struct me4000_info *info) /* Wait until /INIT pin is set */ udelay(20); - if (!inl(info->plx_regbase + PLX_INTCSR) & 0x20) { + if (!(inl(info->plx_regbase + PLX_INTCSR) & 0x20)) { printk(KERN_ERR "%s:Can't init Xilinx\n", __func__); return -EIO; } diff --git a/drivers/staging/wlan-ng/p80211wext.c b/drivers/staging/wlan-ng/p80211wext.c index b2c9ea25fa42..338028ae289b 100644 --- a/drivers/staging/wlan-ng/p80211wext.c +++ b/drivers/staging/wlan-ng/p80211wext.c @@ -1580,7 +1580,7 @@ static int p80211wext_set_encodeext(struct net_device *dev, if ( ext->ext_flags & IW_ENCODE_EXT_SET_TX_KEY ) { - if ( ! ext->alg & IW_ENCODE_ALG_WEP) { + if (!(ext->alg & IW_ENCODE_ALG_WEP)) { WLAN_LOG_DEBUG(1,"asked to set a non wep key :("); return -EINVAL; }