From: Trevor Gamblin Date: Mon, 17 Jun 2024 13:50:04 +0000 (-0400) Subject: iio: health: afe4404: make use of regmap_clear_bits(), regmap_set_bits() X-Git-Tag: io_uring-6.11-20240722~8^2~42^2~69 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=9d0142fc9e74b8c8a4b5a0f7d15ea6a69a4376e0;p=linux-block.git iio: health: afe4404: make use of regmap_clear_bits(), regmap_set_bits() Instead of using regmap_update_bits() and passing the mask twice, use regmap_set_bits(). Instead of using regmap_update_bits() and passing val = 0, use regmap_clear_bits(). Suggested-by: Uwe Kleine-König Signed-off-by: Trevor Gamblin Acked-by: Uwe Kleine-König Link: https://patch.msgid.link/20240617-review-v3-24-88d1338c4cca@baylibre.com Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/health/afe4404.c b/drivers/iio/health/afe4404.c index 390fbb6effaf..7f69baa1ed53 100644 --- a/drivers/iio/health/afe4404.c +++ b/drivers/iio/health/afe4404.c @@ -430,9 +430,8 @@ static int afe4404_suspend(struct device *dev) struct afe4404_data *afe = iio_priv(indio_dev); int ret; - ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2, - AFE440X_CONTROL2_PDN_AFE, - AFE440X_CONTROL2_PDN_AFE); + ret = regmap_set_bits(afe->regmap, AFE440X_CONTROL2, + AFE440X_CONTROL2_PDN_AFE); if (ret) return ret; @@ -457,8 +456,8 @@ static int afe4404_resume(struct device *dev) return ret; } - ret = regmap_update_bits(afe->regmap, AFE440X_CONTROL2, - AFE440X_CONTROL2_PDN_AFE, 0); + ret = regmap_clear_bits(afe->regmap, AFE440X_CONTROL2, + AFE440X_CONTROL2_PDN_AFE); if (ret) return ret;