From: Gustavo A. R. Silva <gustavo@embeddedor.com>
Date: Wed, 18 Jul 2018 01:17:33 +0000 (-0500)
Subject: ptp: fix missing break in switch
X-Git-Tag: v4.18-rc6~28^2~1
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=9ba8376ce1e2cbf4ce44f7e4bee1d0648e10d594;p=linux-block.git

ptp: fix missing break in switch

It seems that a *break* is missing in order to avoid falling through
to the default case. Otherwise, checking *chan* makes no sense.

Fixes: 72df7a7244c0 ("ptp: Allow reassigning calibration pin function")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Acked-by: Richard Cochran <richardcochran@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/ptp/ptp_chardev.c b/drivers/ptp/ptp_chardev.c
index 547dbdac9d54..01b0e2bb3319 100644
--- a/drivers/ptp/ptp_chardev.c
+++ b/drivers/ptp/ptp_chardev.c
@@ -89,6 +89,7 @@ int ptp_set_pinfunc(struct ptp_clock *ptp, unsigned int pin,
 	case PTP_PF_PHYSYNC:
 		if (chan != 0)
 			return -EINVAL;
+		break;
 	default:
 		return -EINVAL;
 	}