From: Sergei Shtylyov Date: Sat, 29 Jul 2017 18:07:07 +0000 (+0300) Subject: pinctrl-st: fix of_irq_to_resource() result check X-Git-Tag: v4.14-rc1~142^2~57 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=98c01b19b85d8d87927e8cfa09c4a2a14add9ba2;p=linux-2.6-block.git pinctrl-st: fix of_irq_to_resource() result check of_irq_to_resource() has recently been fixed to return negative error #'s along with 0 in case of failure, however the ST driver still only regards 0 as failure indication -- fix it up. Fixes: 7a4228bbff76 ("of: irq: use of_irq_get() in of_irq_to_resource()") Signed-off-by: Sergei Shtylyov Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c index 7ac8b1e033fe..70dd2e3b2533 100644 --- a/drivers/pinctrl/pinctrl-st.c +++ b/drivers/pinctrl/pinctrl-st.c @@ -1521,7 +1521,7 @@ static int st_gpiolib_register_bank(struct st_pinctrl *info, * [irqN]----> [gpio-bank (n)] */ - if (of_irq_to_resource(np, 0, &irq_res)) { + if (of_irq_to_resource(np, 0, &irq_res) > 0) { gpio_irq = irq_res.start; gpiochip_set_chained_irqchip(&bank->gpio_chip, &st_gpio_irqchip, gpio_irq, st_gpio_irq_handler);