From: Himangi Saraogi <himangi774@gmail.com>
Date: Wed, 12 Mar 2014 19:25:20 +0000 (+0530)
Subject: staging:rtl8187se: Fix sparse warning in right shift
X-Git-Tag: v3.15-rc1~139^2~421
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=983b4122315a224651c1745096473ad1902e2868;p=linux-2.6-block.git

staging:rtl8187se: Fix sparse warning in right shift

This patch fixes the following sparse warning:
drivers/staging/rtl8187se/r8180_core.c:1328:40: warning: right shift by bigger than source value
by adding parenthesis.

Signed-off-by: Himangi Saraogi <himangi774@gmail.com>
Acked-by: Bob Copeland <me@bobcopeland.com>
Signed-off-by: Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@intel.com>
---

diff --git a/drivers/staging/rtl8187se/r8180_core.c b/drivers/staging/rtl8187se/r8180_core.c
index 7938ad8d4957..79ec26317598 100644
--- a/drivers/staging/rtl8187se/r8180_core.c
+++ b/drivers/staging/rtl8187se/r8180_core.c
@@ -1324,8 +1324,8 @@ static void rtl8180_rx(struct net_device *dev)
 			priv->rx_skb_complete = 1;
 		}
 
-		signal = (unsigned char)(*(priv->rxringtail + 3) &
-			0x00ff0000) >> 16;
+		signal = (unsigned char)((*(priv->rxringtail + 3) &
+			0x00ff0000) >> 16);
 		signal = (signal & 0xfe) >> 1;
 
 		quality = (unsigned char)((*(priv->rxringtail+3)) & (0xff));