From: Rafał Miłecki Date: Tue, 23 Nov 2021 22:15:21 +0000 (+0100) Subject: phy: bcm-ns-usb2: improve printing ref clk errors X-Git-Tag: v5.17-rc1~82^2~30^2~50 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=97ba12d3feca68dd240ba49c9559d9a3e13cf0cd;p=linux-2.6-block.git phy: bcm-ns-usb2: improve printing ref clk errors Improve message & use dev_err_probe() helper which prints actual error (helpful for debugging) and deals with -EPROBE_DEFER. Signed-off-by: Rafał Miłecki Reviewed-by: Florian Fainelli Link: https://lore.kernel.org/r/20211123221521.25323-1-zajec5@gmail.com Signed-off-by: Vinod Koul --- diff --git a/drivers/phy/broadcom/phy-bcm-ns-usb2.c b/drivers/phy/broadcom/phy-bcm-ns-usb2.c index 98d32729a45d..6a36e187d100 100644 --- a/drivers/phy/broadcom/phy-bcm-ns-usb2.c +++ b/drivers/phy/broadcom/phy-bcm-ns-usb2.c @@ -132,7 +132,7 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev) usb2->ref_clk = devm_clk_get(dev, "phy-ref-clk"); if (IS_ERR(usb2->ref_clk)) { - dev_err(dev, "Clock not defined\n"); + dev_err_probe(dev, PTR_ERR(usb2->ref_clk), "failed to get ref clk\n"); return PTR_ERR(usb2->ref_clk); }