From: Logan Gunthorpe Date: Wed, 27 Jul 2022 21:05:58 +0000 (-0600) Subject: md/raid5: Drop unnecessary call to r5c_check_stripe_cache_usage() X-Git-Tag: for-5.20/block-2022-08-04~14 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=9734fe7bd53f85206edee58e0271dbf214c2059c;p=linux-block.git md/raid5: Drop unnecessary call to r5c_check_stripe_cache_usage() Now that raid5_get_active_stripe() has been refactored it is appearant that r5c_check_stripe_cache_usage() doesn't need to be called in the wait_for_stripe branch. r5c_check_stripe_cache_usage() will only conditionally call r5l_wake_reclaim(), but that function is called two lines later. Drop the call for cleanup. Reported-by: Martin Oliveira Signed-off-by: Logan Gunthorpe Signed-off-by: Song Liu Signed-off-by: Jens Axboe --- diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c index 33a364ee6b20..6a0abcb153b0 100644 --- a/drivers/md/raid5.c +++ b/drivers/md/raid5.c @@ -810,7 +810,6 @@ wait_for_stripe: if (noblock) goto out; - r5c_check_stripe_cache_usage(conf); set_bit(R5_INACTIVE_BLOCKED, &conf->cache_state); r5l_wake_reclaim(conf->log, 0); wait_event_lock_irq(conf->wait_for_stripe,