From: John Keeping Date: Mon, 12 Aug 2024 14:35:55 +0000 (+0100) Subject: media: platform: rga: fix 32-bit DMA limitation X-Git-Tag: v6.13-rc1~149^2~193 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=953c03d8cb41d08fe6994f5d94c4393ac9da2f13;p=linux-block.git media: platform: rga: fix 32-bit DMA limitation The destination buffer flags are assigned twice but source is not set in what looks like a copy+paste mistake. Assign the source queue flags so the 32-bit DMA limitation is handled consistently. Fixes: ec9ef8dda2a2 ("media: rockchip: rga: set dma mask to 32 bits") Cc: Signed-off-by: John Keeping Reviewed-by: Michael Tretter Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c index 0e768f3e9eda..de532b7ecd74 100644 --- a/drivers/media/platform/rockchip/rga/rga.c +++ b/drivers/media/platform/rockchip/rga/rga.c @@ -102,7 +102,7 @@ queue_init(void *priv, struct vb2_queue *src_vq, struct vb2_queue *dst_vq) src_vq->drv_priv = ctx; src_vq->ops = &rga_qops; src_vq->mem_ops = &vb2_dma_sg_memops; - dst_vq->gfp_flags = __GFP_DMA32; + src_vq->gfp_flags = __GFP_DMA32; src_vq->buf_struct_size = sizeof(struct rga_vb_buffer); src_vq->timestamp_flags = V4L2_BUF_FLAG_TIMESTAMP_COPY; src_vq->lock = &ctx->rga->mutex;