From: Tomer Maimon Date: Tue, 16 Jul 2024 19:40:04 +0000 (+0300) Subject: pinctrl: nuvoton: npcm8xx: clear polarity before set both edge X-Git-Tag: v6.12-rc1~93^2~33 X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=92f5f86b064f1c50c33c74cb087bfbe3e53479d0;p=linux-block.git pinctrl: nuvoton: npcm8xx: clear polarity before set both edge Clear polarity before setting both edges to ensure that the polarity is in the same state before configuring events for both edges Signed-off-by: Tomer Maimon Link: https://lore.kernel.org/20240716194008.3502068-4-tmaimon77@gmail.com Signed-off-by: Linus Walleij --- diff --git a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c index 2df735947d86..7985400de12a 100644 --- a/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c +++ b/drivers/pinctrl/nuvoton/pinctrl-npcm8xx.c @@ -241,6 +241,7 @@ static int npcmgpio_set_irq_type(struct irq_data *d, unsigned int type) npcm_gpio_set(&bank->gc, bank->base + NPCM8XX_GP_N_POL, gpio); break; case IRQ_TYPE_EDGE_BOTH: + npcm_gpio_clr(&bank->gc, bank->base + NPCM8XX_GP_N_POL, gpio); npcm_gpio_set(&bank->gc, bank->base + NPCM8XX_GP_N_EVBE, gpio); break; case IRQ_TYPE_LEVEL_LOW: