From: Alexandre Belloni <alexandre.belloni@bootlin.com>
Date: Sun, 18 Aug 2019 22:00:40 +0000 (+0200)
Subject: rtc: class: add debug message when registration fails
X-Git-Tag: for-linus-2019-09-27~34^2~30
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=924068e50a6ca426b8fda1d2c06d6d2bde212136;p=linux-block.git

rtc: class: add debug message when registration fails

Add a message when __rtc_register_device fails because rtc->ops is NULL.
This may only happen when developing a new driver so use dev_dbg to avoid
compiling it in by default.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20190818220041.17833-1-alexandre.belloni@bootlin.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
---

diff --git a/drivers/rtc/class.c b/drivers/rtc/class.c
index 0f492b0940b3..9458e6d6686a 100644
--- a/drivers/rtc/class.c
+++ b/drivers/rtc/class.c
@@ -346,8 +346,10 @@ int __rtc_register_device(struct module *owner, struct rtc_device *rtc)
 	struct rtc_wkalrm alrm;
 	int err;
 
-	if (!rtc->ops)
+	if (!rtc->ops) {
+		dev_dbg(&rtc->dev, "no ops set\n");
 		return -EINVAL;
+	}
 
 	rtc->owner = owner;
 	rtc_device_get_offset(rtc);