From: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Date: Wed, 17 Jul 2019 09:03:42 +0000 (-0400)
Subject: media: via-camera: call viafb_pm_unregister in remove()
X-Git-Tag: for-linus-2019-09-27~105^2~267
X-Git-Url: https://git.kernel.dk/?a=commitdiff_plain;h=9230a4cc316b241e641565c377a415cf5d911425;p=linux-block.git

media: via-camera: call viafb_pm_unregister in remove()

The power management hooks were never unregistered, which caused a
crash when unloading the module.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
---

diff --git a/drivers/media/platform/via-camera.c b/drivers/media/platform/via-camera.c
index 4110dc4c771e..d080a263d975 100644
--- a/drivers/media/platform/via-camera.c
+++ b/drivers/media/platform/via-camera.c
@@ -1459,6 +1459,9 @@ static int viacam_remove(struct platform_device *pdev)
 
 	video_unregister_device(&cam->vdev);
 	v4l2_device_unregister(&cam->v4l2_dev);
+#ifdef CONFIG_PM
+	viafb_pm_unregister(&viacam_pm_hooks);
+#endif
 	free_irq(viadev->pdev->irq, cam);
 	via_sensor_power_release(cam);
 	v4l2_ctrl_handler_free(&cam->ctrl_handler);